API updates vs. profile locks and Revisions (to revert changes)

Started by Dan Cornett on Tuesday, October 3, 2017
Problem with this page?

Participants:

Profiles Mentioned:

Related Projects:

Showing all 10 posts
10/3/2017 at 1:57 PM

There has been recent discussion about the fact that API calls can, when invoked by Curator credentials, over-ride the "field locks" placed on a profile.

Moreover, it seems to me that not all API-driven changes to "Basic" fields (those which should be under Revision control) are getting recorded in a way that will "show up" in the Revisions list.

Of course, the problem is that if they don't show up in the Revisions tab, one can't undo the change easily ... let alone see what the change was!

Let's use this thread for both discussion about the lock-over-ride AND about the Revisions of API updates, as I see them as inter-related. That is, if I can trust that the API-updates will show up in the Revision list, then I'm less concerned about Curator-over-ride of locks because I know that they can be reverted if necessary.

10/3/2017 at 1:58 PM

(this is 'public' discussion thread)

10/3/2017 at 2:04 PM

Sorry a little bit off topic, but may be related?

Could it be the API has some more rights than the user has?
I got some information from the SmartCopy check that mentioned the names and some other data from a private profile where all I could see was <private>. It offered a fix but that got an error because it could not access the profile for updating.

10/3/2017 at 2:13 PM

Mike Stangel wrote: (https://www.geni.com/discussions/172419?msg=1172798)
"Should we make the API force you to pass a key to unlock the fields you want to edit? I doubt anyone would make good use of such a change"

If there were such a feature added (that the default would be to not allow over-riding of locks unless an additional "token" were passed), I could see that SmartCopy could be enhanced to use that feature ... perhaps in this way:

The default would be to not over-ride the lock, but if the Curator-user clicked on the "lock-icon" in the SmartCopy panel, that would set (add) that over-ride "token" to that particular field ... that would prevent accidental over-riding of locked fields by forcing the Curator to "open the details" and to explicitly select individual fields to over-ride.

That "over-ride token" could even be one that Geni has to grant to the application ...

However: Two additional factors come to mind:

1) If the Revisions accurately reflected API changes, then I see less need for preventing Curator over-ride (by default).

2) If the Geni-based "unlock-edit-lock" is truly fixed now, there is less reason to want to have the convenience of SmartCopy (or other API-driven updates) to update locked fields. (Which argues for no over-ride via API at all ... but I really hesitate to remove completely such a potentially useful capability from future Apps, such as one to "standardize" location fields based on the dates in the profile and some future database of historical locations, for example.)

10/3/2017 at 2:17 PM

Job: That is exactly the way it should work as far as updating. What may be a 'API bug' is that you could even see (retrieve) that information in the first place via SmartCopy.

Could you start a new API discussion with specific examples of that? It "feels like" a different topic ...

10/3/2017 at 3:42 PM

Dan, oke I will do that when I see a new example (not sure where I saw this)

10/5/2017 at 10:50 AM

Here is an example of Revisions not (currently) showing API updates:

Walter Row

From the 'references', Walter was first added as a "father" with a birth date of 1889 (just the year).
Roughly 35 minutes later, another reference had a precise birth date (12/8/1888).

The Revisions list does not show that. If that detail had gone the other way (from precise date to just a year), there would not be a way to "recover" it (short of remembering there was a precise date and checking each 'link' added by SmartCopy).

Mike Stangel

Private User
10/5/2017 at 11:31 AM

Genealogy is actually a data management discipline, and traceability is key for it. Losing track of changes is a killer and actually the effort to secure the traceability is not really big.

I think all changes shall be tracked, acutally I do not like the current information about the information detail about changes.

10/5/2017 at 4:17 PM

Thanks Dan Cornett this is very disconcerting. We've identified the problem and released a fix, but unfortunately it's not possible to backfill the missing revisions.

10/9/2017 at 12:02 PM

I didn't expect that you'd be able to "back fill"; I'll continue to check on the API updates getting logged, and post specifics if I see any.

Showing all 10 posts

Create a free account or login to participate in this discussion